RHDHPAI-735: Configuration info and other issues to fix #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1060/ @ 04/25/25 07:12:52 |
pabel-rh
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
|
/lgtm |
pabel-rh
added
Technical review done ⛅
jmagak
reviewed
Apr 8, 2025
modules/observe/adoption-insights/proc-install-adoption-insights.adoc
Outdated
Show resolved
Hide resolved
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
evanshortiss
reviewed
Apr 8, 2025
modules/observe/adoption-insights/proc-configure-adoption-insights.adoc
Outdated
Show resolved
Hide resolved
|
Should this PR also mention the segment plugin issue from release notes? I think so |
|
@evanshortiss, Regarding the part on including the disabling the segment plugin, it might be more appropriate to include it in the release notes, especially since it could be addressed in an upcoming release. |
|
@pabel-rh what if someone is excited to try the new feature, but doesn't read the release notes and encounters an error? IMO documentation should be complete for the reader in the now. |
pabel-rh
added
Technical review needed 🔩
linfraze
reviewed
Apr 15, 2025
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
evanshortiss
approved these changes
Apr 22, 2025
pabel-rh
added
Peer review needed 📖
Technical review done ⛅
jmagak
reviewed
Apr 24, 2025
modules/observe/adoption-insights/con-about-adoption-insights.adoc
Outdated
Show resolved
Hide resolved
…adoc Co-authored-by: Judith Magak <[email protected]>
|
New changes are detected. LGTM label has been removed. |
pabel-rh
added
Ready to merge 💂
Peer review done 📘
and removed
Peer review needed 📖
do-no-merge/review-in-progress 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
1.5.x, main, 1.6
Issue:
RHDHPAI-735
Preview:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1060/adoption-insights/