Remove .s2i/environment #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax used in this file is wrong. e.g. DOTNET_STARTUP_PROJECT="samples/MusicStore" should be DOTNET_STARTUP_PROJECT=samples/MusicStore
|
OK. Question: Why remove it over fixing it? Is the prime usecase the template? |
Without documentation the file is here, it magically makes things work (or breaks them by using the wrong syntax.) |
|
On basis of the template (being discussed here redhat-developer/s2i-dotnetcore#27) being the main use case with some documentation, lets remove them. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax used in this file is wrong.
e.g. DOTNET_STARTUP_PROJECT="samples/MusicStore"
should be
DOTNET_STARTUP_PROJECT=samples/MusicStore