2.0: make DOTNET_FRAMEWORK a runtime image envvar and document runtime envvars #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code looks good to me, and the CI failure isn't your fault. We need to sync with the container release. I'll put that out now. |
|
[cibuild] |
jerboaa
reviewed
Oct 17, 2017
2.0/build/test/run
Outdated
| IMAGE_NAME=${IMAGE_NAME:-centos/dotnet-20-centos7} | ||
| RUNTIME_IMAGE_NAME=${RUNTIME_IMAGE_NAME:-dotnet/dotnet-20-runtime-rhel7} | ||
| else | ||
| IMAGE_NAME=${IMAGE_NAME:-centos/dotnet-20-centos7} |
There was a problem hiding this comment.
This doesn't look right. dotnet/dotnet-20-rhel7 maybe?
2.0/build/test/run
Outdated
| RUNTIME_IMAGE_NAME=${RUNTIME_IMAGE_NAME:-dotnet/dotnet-20-runtime-rhel7} | ||
| if [ "$BUILD_CENTOS" = "true" ]; then | ||
| IMAGE_NAME=${IMAGE_NAME:-centos/dotnet-20-centos7} | ||
| RUNTIME_IMAGE_NAME=${RUNTIME_IMAGE_NAME:-dotnet/dotnet-20-runtime-rhel7} |
There was a problem hiding this comment.
This doesn't seem right. Change it to: centos/dotnet-20-runtime-centos7
2.0/runtime/test/run
Outdated
| OPENSHIFT_ONLY=${OPENSHIFT_ONLY:-false} | ||
|
|
||
| test_dir="$(readlink -zf $(dirname "${BASH_SOURCE[0]}"))" | ||
| source ${test_dir}/testcommon | ||
|
|
||
| dotnet_version_serie="2.0" |
There was a problem hiding this comment.
Typo: dotnet_version_series
Thank you for catching these. I hadn't run the build test script stand-alone and changes to it were wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These envvars are interesting for anyone doing their own .s2i scripts.