-
Notifications
You must be signed in to change notification settings - Fork 192
Add CentOS based images for 2.0 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've included the following in the Jenkins pr-checker config:
|
This looks good to me. Nice work! As a follow-up we might want to create a CentOS mirror of this too: |
Then we could also add a mirror of the image stream and the templates should work with centos versions too. |
Can we name the new Dockerfile to something like |
What @tmds said. The convention is Dockerfile being the centos version upstream. Dockerfile.rhel7 being the RHEL-based version. We should stick with that convention as it will make something like this work out-of-the-box on OpenShift:
|
Ah, ok, request withdrawn then, and no complains from my side. |
Introduced with redhat-developer/s2i-dotnetcore#134
Introduced with redhat-developer/s2i-dotnetcore#134
Introduced with redhat-developer/s2i-dotnetcore#134
Introduced with redhat-developer/s2i-dotnetcore#134
Implements #36