Skip to content

Add CentOS based images for 2.0 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 17, 2017
Merged

Add CentOS based images for 2.0 #134

merged 7 commits into from
Oct 17, 2017

Conversation

tmds
Copy link
Member

@tmds tmds commented Oct 16, 2017

Implements #36

@tmds
Copy link
Member Author

tmds commented Oct 16, 2017

I've included the following in the Jenkins pr-checker config:

# Build and test CentOS images
TEST_OPENSHIFT=false BUILD_CENTOS=true ./build.sh

@tmds tmds requested review from aslicerh, omajid and jerboaa October 16, 2017 11:46
@jerboaa
Copy link
Contributor

jerboaa commented Oct 16, 2017

This looks good to me. Nice work!

As a follow-up we might want to create a CentOS mirror of this too:
https://github.com/redhat-developer/dotnet-jenkins-slave

@jerboaa
Copy link
Contributor

jerboaa commented Oct 16, 2017

Then we could also add a mirror of the image stream and the templates should work with centos versions too.

@aslicerh
Copy link
Member

aslicerh commented Oct 16, 2017

Can we name the new Dockerfile to something like Dockerfile.centos? That would keep the naming convention consistent, and it would get in the way less for the container builds, where we currently sym link Dockerfile.rhel7 to Dockerfile.

@tmds
Copy link
Member Author

tmds commented Oct 16, 2017

Can we name the new Dockerfile to something like Dockerfile.centos?

I named this Dockerfile since it seems to be the naming convention for CentOS in the other s2i repos (e.g. nodejs, python).

@jerboaa wdyt?

@jerboaa
Copy link
Contributor

jerboaa commented Oct 16, 2017

Can we name the new Dockerfile to something like Dockerfile.centos?

What @tmds said. The convention is Dockerfile being the centos version upstream. Dockerfile.rhel7 being the RHEL-based version. We should stick with that convention as it will make something like this work out-of-the-box on OpenShift:

 $ oc new-build --strategy=docker --context-dir=2.0/runtime https://github.com/redhat-developer/s2i-dotnetcore

@aslicerh
Copy link
Member

Ah, ok, request withdrawn then, and no complains from my side.

@tmds
Copy link
Member Author

tmds commented Oct 17, 2017

Thank you for review @jerboaa @aslicerh!

@tmds tmds merged commit ee23ced into redhat-developer:master Oct 17, 2017
alexcern added a commit to alexcern/origin that referenced this pull request Nov 13, 2017
alexcern added a commit to alexcern/origin that referenced this pull request Nov 14, 2017
alexcern added a commit to alexcern/origin that referenced this pull request Nov 14, 2017
alexcern added a commit to alexcern/origin that referenced this pull request Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants