Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Commit 308331c

Browse files
committed
collect: Rename specs to clarify intent of testing
Signed-off-by: Andy Sadler <[email protected]>
1 parent 5bca955 commit 308331c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pkg/reconcile/pipeline/handler/collect/impl.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ const (
2626
ErrorReadingDescriptorReason = "ErrorReadingDescriptor"
2727
ErrorReadingBindingReason = "ErrorReadingBinding"
2828
ErrorReadingSecret = "ErrorReadingSecret"
29-
ValueNotFound = "ValueNotFound"
29+
30+
ValueNotFound = "ValueNotFound"
3031
)
3132

3233
func PreFlight(ctx pipeline.Context) {

pkg/reconcile/pipeline/handler/collect/impl_test.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -1030,8 +1030,7 @@ var _ = Describe("Integration Collect definitions + items", func() {
10301030

10311031
})
10321032

1033-
// TODO: spec title should be rephrased: should we have one spec for regression tests?
1034-
var _ = Describe("Issue 943", func() {
1033+
var _ = Describe("Handle invalid sliceOfMap annotations", func() {
10351034
var (
10361035
mockCtrl *gomock.Controller
10371036
)
@@ -1051,7 +1050,7 @@ var _ = Describe("Issue 943", func() {
10511050
configMaps map[string]*unstructured.Unstructured
10521051
}
10531052

1054-
It("retrieve binding data",
1053+
It("should set an error condition",
10551054
func() {
10561055
tc := testCase{
10571056
serviceContent: map[string]interface{}{

0 commit comments

Comments
 (0)