Skip to content

Add java.configuration.maven.defaultMojoExecutionAction #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Just some minor changes might be needed.

@snjeza
Copy link
Contributor Author

snjeza commented Feb 3, 2023

@rgrunber I have updated the PR.

Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ignore was fine. Is there a reason to remove the back-ticks ? Change is fine so I'd just add them back and feel free to merge.

@rgrunber rgrunber merged commit 8476bef into redhat-developer:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants