Skip to content

Change in preference of local odo causes extension bundled odo preference change #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohitsuman opened this issue Sep 9, 2020 · 2 comments
Labels
Milestone

Comments

@mohitsuman
Copy link
Collaborator

Environment
VS Code version: 1.48.2
OS: darwin
Extension version: 0.1.6

Description
If the local odo has experimental flag set as true , then the extension bundled odo also fetches the same preference and this causes the extension to break.

This happens as the preference is globally set.

Error Trace:

Failed to create Component with error 'Error: Command failed: "/Users/mohitsuman/.vscode/extensions/redhat.vscode-openshift-connector-0.1.6/out/tools/darwin/odo" create nodejs:10 comp124 --git https://github.com/mohitsuman/nodejs-ex --ref HEAD --app app123 --project demo-discon
 ✗  flag --git, requires --s2i flag to be set, when in experimental mode.
@mohitsuman
Copy link
Collaborator Author

This can be handled using following:

  1. OpenShift extension bundles use the global preference and create a separate terminal with specific ODO_EXPERIMENTAL env variable to override the global preference for your own dev/test odo, then the two binaries can target to different odo preference

  2. set the location of the global preference file using GLOBALODOCONFIG

@dgolovin dgolovin added kind/enhancement New feature or request priority/major labels Sep 9, 2020
@dgolovin
Copy link
Collaborator

We should investigate if GLOBALODOCONFIG should point to folder or file.

@dgolovin dgolovin added this to the v0.2.5 milestone Mar 23, 2021
@dgolovin dgolovin self-assigned this Mar 23, 2021
@dgolovin dgolovin modified the milestones: v0.2.5, v0.2.6, v0.2.7 May 4, 2021
dgolovin added a commit to dgolovin/vscode-openshift-tools that referenced this issue May 5, 2021
This PR revert changes for redhat-developer#1736.

Signed-off-by: Denis Golovin [email protected]
dgolovin added a commit that referenced this issue May 6, 2021
This PR revert changes for #1736.

Signed-off-by: Denis Golovin [email protected]
@dgolovin dgolovin modified the milestones: v0.2.10, v0.2.11 Aug 18, 2021
@mohitsuman mohitsuman modified the milestones: 1.2.0, 1.3.0 Jan 4, 2023
@mohitsuman mohitsuman modified the milestones: 1.3.0, 1.4.0 Mar 15, 2023
@mohitsuman mohitsuman modified the milestones: 1.4.0, 1.5.0 Mar 23, 2023
@mohitsuman mohitsuman modified the milestones: 1.7.0, 1.8.0 Jun 2, 2023
@datho7561 datho7561 modified the milestones: 1.8.0, 1.9.0 Sep 14, 2023
@mohitsuman mohitsuman modified the milestones: 1.9.0, 1.10.0 Sep 15, 2023
@mohitsuman mohitsuman modified the milestones: 1.10.0, 1.11.0, 1.12.0 Nov 1, 2023
@mohitsuman mohitsuman modified the milestones: 1.13.0, 1.14.0 Apr 2, 2024
@mohitsuman mohitsuman modified the milestones: 1.15.0, 1.16.0 May 30, 2024
@mohitsuman mohitsuman modified the milestones: 1.16.0, 1.17.0 Jun 27, 2024
@mohitsuman mohitsuman modified the milestones: 1.17.0, 1.19.0 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants