Skip to content

New Component from Component Types view flow needs to be cancelled twice to close #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jrichter1 opened this issue Mar 10, 2021 · 0 comments · Fixed by #2018
Closed

New Component from Component Types view flow needs to be cancelled twice to close #2015

jrichter1 opened this issue Mar 10, 2021 · 0 comments · Fixed by #2018
Assignees
@dgolovin
Labels
kind/bug priority/major
Milestone
v0.2.4

Comments

@jrichter1
Copy link
Contributor

Using New Component directly from a devfile/S2I in the component types section. Cancelling on the first step brings the same input box back up immediately and the whole command flow can still be finished. Only cancelling twice will actually close it.
dgolovin added a commit to dgolovin/vscode-openshift-tools that referenced this issue Mar 10, 2021
@dgolovin
End New Component workflow when application selection canceled

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8e9c7c6 
This PR fixes redhat-developer#2015.

Signed-off-by: Denis Golovin [email protected]
@dgolovin dgolovin mentioned this issue Mar 10, 2021
Merged
@dgolovin dgolovin self-assigned this Mar 10, 2021
dgolovin added a commit that referenced this issue Mar 10, 2021
@dgolovin
End New Component workflow when application selection canceled
97e189b 
This PR fixes #2015.

Signed-off-by: Denis Golovin [email protected]
@dgolovin dgolovin added this to the v0.2.4 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgolovin dgolovin

Labels
kind/bug priority/major
Projects
None yet
Milestone
v0.2.4
Development

Successfully merging a pull request may close this issue.

End New Component workflow when application selection canceled dgolovin/vscode-openshift-tools
2 participants
@dgolovin @jrichter1