Skip to content

VSCode Commands called from navigation/inline group or with welcome page button don't report exceptions #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dgolovin opened this issue Mar 23, 2021 · 0 comments
Closed

VSCode Commands called from navigation/inline group or with welcome page button don't report exceptions #2061

dgolovin opened this issue Mar 23, 2021 · 0 comments
Assignees
@dgolovin
Labels
kind/enhancement New feature or request priority/major
Milestone
v0.2.5

Comments

@dgolovin
Copy link
Collaborator

Always report errors in vsCommand.ts command wrapper with window.showErrorMessage() rather than let vscode handle it.
@dgolovin dgolovin added kind/enhancement New feature or request priority/major labels Mar 23, 2021
@dgolovin dgolovin added this to the v0.2.5 milestone Mar 23, 2021
@dgolovin dgolovin self-assigned this Mar 23, 2021
dgolovin added a commit to dgolovin/vscode-openshift-tools that referenced this issue Mar 25, 2021
@dgolovin
Show error message for exceptions in commands
96b8fa7 
This PR fixes redhat-developer#2061.

Signed-off-by: Denis Golovin [email protected]
@dgolovin dgolovin mentioned this issue Mar 25, 2021
Merged
dgolovin added a commit that referenced this issue Mar 25, 2021
@dgolovin
Show error message for exceptions in commands
b6a1233 
This PR fixes #2061.

Signed-off-by: Denis Golovin [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgolovin dgolovin

Labels
kind/enhancement New feature or request priority/major
Projects
None yet
Milestone
v0.2.5
Development

No branches or pull requests
1 participant
@dgolovin