Skip to content

'New Componen' command does not support multiple registries #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dgolovin opened this issue May 6, 2021 · 0 comments
Closed

'New Componen' command does not support multiple registries #2117

dgolovin opened this issue May 6, 2021 · 0 comments
Assignees
@dgolovin
Labels
kind/feature priority/blocker
Milestone
v0.2.5

Comments

@dgolovin
Copy link
Collaborator

dgolovin commented May 6, 2021

New Component command workflow shows component types as plain list build out of json output form odo. If there is more than one registries then there are multiple problems:

  1. Duplicated components in quick pick
  2. Command does not distinguish components with the same time from multiple registries
  3. There is not indication of registry for component in quick pick
@dgolovin dgolovin added this to the v0.2.5 milestone May 6, 2021
@dgolovin dgolovin self-assigned this May 6, 2021
dgolovin added a commit to dgolovin/vscode-openshift-tools that referenced this issue May 6, 2021
@dgolovin
Title
9ad8e37 
This PR fixes redhat-developer#2115 and fixes redhat-developer#2117.

Introduce registry name as part of component type quickpick lable.
Similar to s2i components the label is formed as

<devfile-component-type-name/registry-name>

Sort component types by name of the component.

Signed-off-by: Denis Golovin [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgolovin dgolovin

Labels
kind/feature priority/blocker
Projects
None yet
Milestone
v0.2.5
Development

No branches or pull requests
1 participant
@dgolovin