Skip to content

Update ComponentKind concept to support Deployment Configs and Deployment resources reported as otherComponents by odo #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dgolovin opened this issue Dec 2, 2021 · 3 comments
Closed

Update ComponentKind concept to support Deployment Configs and Deployment resources reported as otherComponents by odo #2307

dgolovin opened this issue Dec 2, 2021 · 3 comments
Assignees
@dgolovin
Labels
kind/task priority/major
Milestone
0.4.0

Comments

@dgolovin
Copy link
Collaborator

dgolovin commented Dec 2, 2021 •
edited
Loading

Previous implementations have to support two component kinds S2I and Devfile. Now Devfile and Other components should be shown in OpenShift Application Explorer.
@dgolovin dgolovin added this to the v0.3.0 milestone Dec 2, 2021
@dgolovin dgolovin self-assigned this Dec 2, 2021
dgolovin added a commit to dgolovin/vscode-openshift-tools that referenced this issue Dec 2, 2021
@dgolovin
Remove component kind parameter from Component.delete() command
5324f49 
This PR related to redhat-developer#2307.

Signed-off-by: Denis Golovin [email protected]
@dgolovin dgolovin mentioned this issue Dec 2, 2021
Merged
dgolovin added a commit that referenced this issue Dec 2, 2021
@dgolovin
Remove component kind parameter from Component.delete() command
a75602a 
This PR related to #2307.

Signed-off-by: Denis Golovin [email protected]
@mohitsuman
Copy link
Collaborator

@dgolovin Based on PR #2308, do you think this issue is fixed and can be closed ?

@dgolovin
Copy link
Collaborator Author

@mohitsuman nope, it is all over the code.

@dgolovin dgolovin changed the title Remove ComponentKind concept from API Update ComponentKind concept to support Deployment Configs and Deployment resources reported as otherComponents by odo Feb 2, 2022
@dgolovin
Copy link
Collaborator Author

dgolovin commented Feb 2, 2022

This issue is related to #2324 which is scheduled for v0.3.1. Moving it ot milestone v0.3.1.

@dgolovin dgolovin modified the milestones: v0.3.0, v0.3.1 Feb 2, 2022
@mohitsuman mohitsuman modified the milestones: v0.3.1, v0.3.2 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgolovin dgolovin

Labels
kind/task priority/major
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@dgolovin @mohitsuman