Skip to content

Migrate from istanbul to nyc #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datho7561 opened this issue Jul 14, 2023 · 0 comments
Open

Migrate from istanbul to nyc #3025

datho7561 opened this issue Jul 14, 2023 · 0 comments

Comments

@datho7561
Copy link
Contributor

When running npm ci, I get the following message:

npm WARN deprecated [email protected]: This module is no longer maintained, try this instead:
npm WARN deprecated   npm i nyc
npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives.

It appears that nyc is the replacement CLI tool for collecting coverage for tests. It would be nice to migrate to it.

@vrubezhny vrubezhny self-assigned this Dec 9, 2024
@vrubezhny vrubezhny moved this to 📝 In Progress in IDE Cloudaptors Dec 9, 2024
@vrubezhny vrubezhny moved this from 📝 In Progress to 📋 Backlog in IDE Cloudaptors Jan 22, 2025
vrubezhny pushed a commit to vrubezhny/vscode-openshift-tools that referenced this issue Feb 27, 2025
Currently not working example of using `nyc`: changed to nyc for
coverage in `unit` tests:

```
npm run test:coverage
```

The source instrumenting is done by `npm run test:instrument` (invoked as part of `test:coverage` command)

The `istanbul` dependecy is not removed yet due to not changed:
- test/coverage.ts
- test/ui/cluster-ui-test.ts
- test/ui/public-ui-test.js
depending on `istanbul` API, which is subject to change after `nyc` finally provides a valuable coverage report.

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny pushed a commit to vrubezhny/vscode-openshift-tools that referenced this issue Feb 27, 2025
Currently not working example of using `nyc`: changed to nyc for
coverage in `unit` tests:

```
npm run test:coverage
```

The source instrumenting is done by `npm run test:instrument` (invoked as part of `test:coverage` command)

The `istanbul` dependecy is not removed yet due to not changed:
- test/coverage.ts
- test/ui/cluster-ui-test.ts
- test/ui/public-ui-test.js
depending on `istanbul` API, which is subject to change after `nyc` finally provides a valuable coverage report.

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny pushed a commit to vrubezhny/vscode-openshift-tools that referenced this issue Feb 27, 2025
Currently not working example of using `nyc`: changed to nyc for
coverage in `unit` tests:

```
npm run test:coverage
```

The source instrumenting is done by `npm run test:instrument` (invoked as part of `test:coverage` command)

The `istanbul` dependecy is not removed yet due to not changed:
- test/coverage.ts
- test/ui/cluster-ui-test.ts
- test/ui/public-ui-test.js
depending on `istanbul` API, which is subject to change after `nyc` finally provides a valuable coverage report.

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny pushed a commit to vrubezhny/vscode-openshift-tools that referenced this issue Feb 28, 2025
Currently not working example of using `nyc`: changed for test coverage in `unit` tests:

```
npm run test:coverage
```

The source instrumenting is done by `npm run test:instrument` (invoked as part of `test:coverage` command)

The `istanbul` dependecy is not removed yet due to not changed:
- test/coverage.ts
- test/ui/cluster-ui-test.ts
- test/ui/public-ui-test.js
depending on `istanbul` API, which is subject to change after `nyc` finally provides a valuable coverage report.

Fixes: redhat-developer#3025

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny pushed a commit to vrubezhny/vscode-openshift-tools that referenced this issue Mar 4, 2025
Currently not working example of using `nyc`: changed for test coverage in `unit` tests:

```
npm run test:coverage
```

The source instrumenting is done by `npm run test:instrument` (invoked as part of `test:coverage` command)

The `istanbul` dependecy is not removed yet due to not changed:
- test/coverage.ts
- test/ui/cluster-ui-test.ts
- test/ui/public-ui-test.js
depending on `istanbul` API, which is subject to change after `nyc` finally provides a valuable coverage report.

Fixes: redhat-developer#3025

Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny pushed a commit to vrubezhny/vscode-openshift-tools that referenced this issue Mar 4, 2025
Currently not working example of using `nyc`: changed for test coverage in `unit` tests:

```
npm run test:coverage
```

The source instrumenting is done by `npm run test:instrument` (invoked as part of `test:coverage` command)

The `istanbul` dependecy is not removed yet due to not changed:
- test/coverage.ts
- test/ui/cluster-ui-test.ts
- test/ui/public-ui-test.js
depending on `istanbul` API, which is subject to change after `nyc` finally provides a valuable coverage report.

Fixes: redhat-developer#3025

Signed-off-by: Victor Rubezhny <[email protected]>
@vrubezhny vrubezhny moved this from 📋 Backlog to 📝 In Progress in IDE Cloudaptors Mar 5, 2025
@adietish adietish moved this from 📝 In Progress to 📋 Backlog in IDE Cloudaptors Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants