Skip to content

"Select All" functionality for OpenShift Terminal #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
datho7561 opened this issue Aug 29, 2023 · 0 comments · Fixed by #3360
Closed

"Select All" functionality for OpenShift Terminal #3137

datho7561 opened this issue Aug 29, 2023 · 0 comments · Fixed by #3360
Assignees
@datho7561
Labels
kind/enhancement New feature or request
Milestone
1.10.0

Comments

@datho7561
Copy link
Contributor

See this comment from Victor.

There are context menu items for cut, copy and paste, but not "Select All".

I don't know if it's feasible to add another context menu, but it would be nice to have some method of doing "Select All" even if it's not in a context menu.
@datho7561 datho7561 added the kind/enhancement New feature or request label Aug 29, 2023
@datho7561 datho7561 mentioned this issue Sep 27, 2023
Merged
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Sep 27, 2023
@datho7561
Terminal: keybinding and context menu for copy & select all
20023c9 
Adds the following keybindings to the OpenShift terminal:
- `Ctrl+Shift+C`: copy selection
- `Ctrl+Shift+A`: select all text

Hide the existing broken context menu (provided by VS Code)
and replace it with one with "Select All" and "Copy" items that
actually work.
This context menu imitates the style of VS Code's context menu.

Closes redhat-developer#3353, closes redhat-developer#3137

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 self-assigned this Sep 27, 2023
@datho7561 datho7561 added this to the 1.10.0 milestone Sep 27, 2023
@datho7561 datho7561 moved this to 👀 In review in IDE Cloudaptors Sep 27, 2023
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Sep 29, 2023
@datho7561
Terminal: keybinding and context menu for copy & select all
5f9f265 
Adds the following keybindings to the OpenShift terminal:
- `Ctrl+Shift+C`: copy selection
- `Ctrl+Shift+A`: select all text

Hide the existing broken context menu (provided by VS Code)
and replace it with one with "Select All" and "Copy" items that
actually work.
This context menu imitates the style of VS Code's context menu.

Closes redhat-developer#3353, closes redhat-developer#3137

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit that referenced this issue Sep 29, 2023
@datho7561
Terminal: keybinding and context menu for copy & select all
24e4830 
Adds the following keybindings to the OpenShift terminal:
- `Ctrl+Shift+C`: copy selection
- `Ctrl+Shift+A`: select all text

Hide the existing broken context menu (provided by VS Code)
and replace it with one with "Select All" and "Copy" items that
actually work.
This context menu imitates the style of VS Code's context menu.

Closes #3353, closes #3137

Signed-off-by: David Thompson <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
kind/enhancement New feature or request
Projects
IDE Cloudaptors
Archived in project
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

Terminal: keybinding and context menu for copy & select all datho7561/vscode-openshift-tools
1 participant
@datho7561