Skip to content

Developer Sandbox Login experience enhancement #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mohitsuman opened this issue Jan 24, 2024 · 1 comment · Fixed by #3844
Closed

Developer Sandbox Login experience enhancement #3838

mohitsuman opened this issue Jan 24, 2024 · 1 comment · Fixed by #3844
Assignees
@datho7561
Labels
kind/enhancement New feature or request
Milestone
1.12.0

Comments

@mohitsuman
Copy link
Collaborator

Improve the developer sandbox login experience using Builder service account.
@mohitsuman mohitsuman added this to the 1.13.0 milestone Jan 24, 2024
@datho7561 datho7561 added the kind/enhancement New feature or request label Jan 25, 2024
@datho7561
Copy link
Contributor

Here's what I've figured out so far:

  1. OpenShift Sandbox has a builder service account, but by default the account doesn't have enough permissions to do anything useful on the cluster. There is a role called edit that the user account. If we use a role binding to assign the builder account this role, then it can be used for vscode-openshift
  2. The service account pipeline already has the edit role, so we can try using that account instead of builder

datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Jan 25, 2024
@datho7561
Switch to service account after logging into OpenShift Sandbox
a1b219d 
The service account will remain authenticated for longer than 15
minutes.

To try this out:
1. Log into an OpenShift Sandbox cluster using the Login workflow
2. Run `oc whoami`. You should see a reference to `pipeline`, which is the
   serviceaccount that's being used
3. The Application Explorer should display you as logged in and work as
   expected

Closes redhat-developer#3838

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 mentioned this issue Jan 25, 2024
Merged
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Jan 29, 2024
@datho7561
Switch to service account after logging into OpenShift Sandbox
6b56fd9 
The service account will remain authenticated for longer than 15
minutes.

To try this out:
1. Log into an OpenShift Sandbox cluster using the Login workflow
2. Run `oc whoami`. You should see a reference to `pipeline`, which is the
   serviceaccount that's being used
3. The Application Explorer should display you as logged in and work as
   expected

Closes redhat-developer#3838

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 moved this to 🏗 In progress in IDE Cloudaptors Jan 29, 2024
@datho7561 datho7561 moved this from 🏗 In progress to 👀 In review in IDE Cloudaptors Jan 29, 2024
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 1, 2024
@datho7561
Switch to service account after logging into OpenShift Sandbox
71c1e4f 
The service account will remain authenticated for longer than 15
minutes.

To try this out:
1. Log into an OpenShift Sandbox cluster using the Login workflow
2. Run `oc whoami`. You should see a reference to `pipeline`, which is the
   serviceaccount that's being used
3. The Application Explorer should display you as logged in and work as
   expected

Closes redhat-developer#3838

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 1, 2024
@datho7561
Switch to service account after logging into OpenShift Sandbox
5c6c680 
The service account will remain authenticated for longer than 15
minutes.

To try this out:
1. Log into an OpenShift Sandbox cluster using the Login workflow
2. Run `oc whoami`. You should see a reference to `pipeline`, which is the
   serviceaccount that's being used
3. The Application Explorer should display you as logged in and work as
   expected

Closes redhat-developer#3838

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 2, 2024
@datho7561
Switch to service account after logging into OpenShift Sandbox
8555d78 
The service account will remain authenticated for longer than 15
minutes.

To try this out:
1. Log into an OpenShift Sandbox cluster using the Login workflow
2. Run `oc whoami`. You should see a reference to `pipeline`, which is the
   serviceaccount that's being used
3. The Application Explorer should display you as logged in and work as
   expected

Closes redhat-developer#3838

Signed-off-by: David Thompson <[email protected]>
vrubezhny pushed a commit that referenced this issue Feb 5, 2024
@datho7561 @vrubezhny
Switch to service account after logging into OpenShift Sandbox
eb06f1c 
The service account will remain authenticated for longer than 15
minutes.

To try this out:
1. Log into an OpenShift Sandbox cluster using the Login workflow
2. Run `oc whoami`. You should see a reference to `pipeline`, which is the
   serviceaccount that's being used
3. The Application Explorer should display you as logged in and work as
   expected

Closes #3838

Signed-off-by: David Thompson <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Feb 5, 2024
@vrubezhny vrubezhny modified the milestones: 1.13.0, 1.12.0 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
kind/enhancement New feature or request
Projects
IDE Cloudaptors
Status: ✅ Done
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

Switch to service account after logging into OpenShift Sandbox datho7561/vscode-openshift-tools
3 participants
@vrubezhny @mohitsuman @datho7561