Skip to content

Improve sandbox workflow and go directly to 'Copy Login Command' page #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

dgolovin
Copy link
Collaborator

Signed-off-by: Denis Golovin [email protected]

@dgolovin dgolovin force-pushed the improve-sandbox-workflow branch from 75f6317 to 9f2d5fc Compare October 14, 2022 00:07
Signed-off-by: Denis Golovin [email protected]
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 67.08% // Head: 66.91% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (4b745d7) compared to base (cce2f53).
Patch coverage: 18.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2568      +/-   ##
==========================================
- Coverage   67.08%   66.91%   -0.17%     
==========================================
  Files          56       56              
  Lines        3679     3691      +12     
  Branches      671      673       +2     
==========================================
+ Hits         2468     2470       +2     
- Misses       1211     1221      +10     
Impacted Files Coverage Δ
src/webview/cluster/clusterViewLoader.ts 9.40% <0.00%> (+0.04%) ⬆️
src/openshift/cluster.ts 77.93% <12.50%> (-3.05%) ⬇️
src/openshift/sandbox.ts 50.00% <40.00%> (-2.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mohitsuman mohitsuman merged commit 400a4da into redhat-developer:main Oct 17, 2022
@dgolovin dgolovin added this to the 1.0.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants