-
Notifications
You must be signed in to change notification settings - Fork 59
Components tree view not get refreshed #3318 #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components tree view not get refreshed #3318 #3377
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
==========================================
+ Coverage 37.03% 37.12% +0.08%
==========================================
Files 77 77
Lines 5373 5385 +12
Branches 1035 1034 -1
==========================================
+ Hits 1990 1999 +9
- Misses 3383 3386 +3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to work for me. I put a breakpoint on the added line, and it's never hit when I delete or move the Devfile.
And when I set a breakpoint on the added line - it successfully gets hit in debugger... ... because actually we have everything in place and the component folders was correctly updating - the only component tree view was not updated. |
Fixes: redhat-developer#3318 Signed-off-by: Victor Rubezhny <[email protected]>
e41c924
to
0862004
Compare
@datho7561 I've updated the PR, could you please give it another try? |
I think that what I was actually running into was that any newly added folders don't get the listener installed. I'll do a bit more testing. |
I can't replicate what happened before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Thanks, Victor!
This purely can be a reason for not working - but this is another issue - with this PR the removal of a component Reacting on a new component folder added (and a |
Fixes: #3318