Skip to content

Components tree view not get refreshed #3318 #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vrubezhny
Copy link
Contributor

Fixes: #3318

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (83dac0f) 37.03% compared to head (0862004) 37.12%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3377      +/-   ##
==========================================
+ Coverage   37.03%   37.12%   +0.08%     
==========================================
  Files          77       77              
  Lines        5373     5385      +12     
  Branches     1035     1034       -1     
==========================================
+ Hits         1990     1999       +9     
- Misses       3383     3386       +3     
Files Coverage Δ
src/util/credentialManager.ts 83.33% <100.00%> (+0.98%) ⬆️
src/util/workspace.ts 38.46% <100.00%> (+0.96%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work for me. I put a breakpoint on the added line, and it's never hit when I delete or move the Devfile.

@vrubezhny
Copy link
Contributor Author

vrubezhny commented Sep 29, 2023

Hm...
screencast-component-view-refresh-on-devfile-delete

And when I set a breakpoint on the added line - it successfully gets hit in debugger...
@datho7561 Are you sure you're not run into too many files open like issue when testing?

... because actually we have everything in place and the component folders was correctly updating - the only component tree view was not updated.

@vrubezhny vrubezhny force-pushed the fix-components-tree-refresh-on-devfile-remove branch from e41c924 to 0862004 Compare September 29, 2023 17:52
@vrubezhny
Copy link
Contributor Author

@datho7561 I've updated the PR, could you please give it another try?

@vrubezhny vrubezhny requested a review from datho7561 September 29, 2023 17:54
@datho7561
Copy link
Contributor

I think that what I was actually running into was that any newly added folders don't get the listener installed. I'll do a bit more testing.

@datho7561
Copy link
Contributor

I can't replicate what happened before.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks, Victor!

@vrubezhny
Copy link
Contributor Author

vrubezhny commented Sep 29, 2023

I think that what I was actually running into was that any newly added folders don't get the listener installed. I'll do a bit more testing.

This purely can be a reason for not working - but this is another issue - with this PR the removal of a component devfile.yaml was fixed.

Reacting on a new component folder added (and a devfile.yaml placed into that folder) - is a different story.

@datho7561 datho7561 merged commit 9aa147e into redhat-developer:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components tree view not get refreshed
2 participants