Skip to content

remote deployment functionality added #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

msivasubramaniaan
Copy link
Collaborator

Fixes: #3351

Signed-off-by: msivasubramaniaan <[email protected]>
@mohitsuman
Copy link
Collaborator

@msivasubramaniaan please add a video for this feature workflow.

Signed-off-by: msivasubramaniaan <[email protected]>
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 126 lines in your changes are missing coverage. Please review.

Comparison is base (f11efa8) 35.43% compared to head (1afa70e) 34.44%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3491      +/-   ##
==========================================
- Coverage   35.43%   34.44%   -0.99%     
==========================================
  Files          79       81       +2     
  Lines        5613     5777     +164     
  Branches     1116     1156      +40     
==========================================
+ Hits         1989     1990       +1     
- Misses       3624     3787     +163     
Files Coverage Δ
src/tools.ts 83.87% <100.00%> (ø)
src/serverlessFunction/view.ts 35.04% <50.00%> (+0.26%) ⬆️
src/serverlessFunction/commands.ts 6.81% <0.00%> (-0.42%) ⬇️
src/tekton/tekton.ts 25.00% <25.00%> (ø)
src/serverlessFunction/knative.ts 15.38% <15.38%> (ø)
src/serverlessFunction/functions.ts 9.30% <7.69%> (-0.48%) ⬇️
src/serverlessFunction/git/git.ts 11.84% <11.84%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datho7561
Copy link
Contributor

remote-deploy.mp4

@datho7561
Copy link
Contributor

A few bugs I ran into, I'll try to address them:

  • The version of func that we provide has a bug that prevents the PipelineRun from cloning the git repository. Updating to the latest version fixes this. I can do it manually this time, but we should set up a GitHub Action to do this; I've created an issue for this.
  • There are two warning popups that appear that say the local branch hasn't been pushed to the remote, even when it has been.

- Update `func` CLI to the latest version
- Adjust to API change for fetching refs in the vscode-git extension API

Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 merged commit 4cb7226 into redhat-developer:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote deployment on serverless function
3 participants