Skip to content

add odo link implementation #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2018
Merged

Conversation

mohitsuman
Copy link
Collaborator

Fix #423

@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #425 into master will increase coverage by 0.04%.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   81.27%   81.31%   +0.04%     
==========================================
  Files          20       20              
  Lines         908      910       +2     
  Branches      145      145              
==========================================
+ Hits          738      740       +2     
  Misses        170      170
Impacted Files Coverage Δ
src/extension.ts 100% <100%> (ø) ⬆️
src/odo.ts 77.96% <100%> (+0.12%) ⬆️
src/openshift/service.ts 90.24% <100%> (+16.24%) ⬆️
src/openshift/component.ts 70.66% <7.69%> (-4.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb9c29...2c0e462. Read the comment docs.

Copy link
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Service provisioning is a long process, that is why we should use --wait option when linking components.

@dgolovin dgolovin merged commit 8a741c4 into redhat-developer:master Dec 1, 2018
@dgolovin dgolovin removed the review label Dec 1, 2018
@mohitsuman mohitsuman deleted the gh-423 branch June 16, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants