Skip to content

Prettify json in OpenShift Output Channel #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2019

Conversation

sudhirverma
Copy link
Contributor

@sudhirverma sudhirverma commented Jun 10, 2019

Fix: #819

@sudhirverma sudhirverma requested a review from dgolovin June 10, 2019 11:06
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #888 into master will decrease coverage by 1.69%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #888     +/-   ##
=========================================
- Coverage   93.43%   91.73%   -1.7%     
=========================================
  Files          23       24      +1     
  Lines        1416     1464     +48     
  Branches      234      238      +4     
=========================================
+ Hits         1323     1343     +20     
- Misses         93      121     +28
Impacted Files Coverage Δ
src/cli.ts 94.73% <91.66%> (-1.93%) ⬇️
src/openshift/component.ts 98.42% <0%> (-1.58%) ⬇️
src/extension.ts 75.57% <0%> (-0.81%) ⬇️
src/k8s/deployment.ts 12% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0146d70...a648739. Read the comment docs.

@mohitsuman
Copy link
Collaborator

@sudhirverma Please share the changed output screenshot after this PR is applied.

@dgolovin
Copy link
Collaborator

@mohitsuman screenshots are added to the issue description.

@dgolovin dgolovin merged commit de457dd into redhat-developer:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettify json in OpenShift Output Channel
3 participants