-
Notifications
You must be signed in to change notification settings - Fork 60
Provide cluster and usernames from k8 config for login #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 91.73% 91.74% +0.01%
==========================================
Files 24 25 +1
Lines 1464 1503 +39
Branches 238 247 +9
==========================================
+ Hits 1343 1379 +36
- Misses 121 124 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
===========================================
- Coverage 91.73% 81.73% -10.01%
===========================================
Files 24 25 +1
Lines 1464 1511 +47
Branches 238 250 +12
===========================================
- Hits 1343 1235 -108
- Misses 121 276 +155
Continue to review full report at Codecov.
|
testPR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should handle corner cases, like empty ~/.kube/config or no config at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not mix dependency update with new features and fixes.
Fix #671
Cluster View

UserName

The new UI also mentions the current context of from k8 config.