Deploy to OpenShift command #316

datho7561 · 2020-10-30T19:40:38Z

Uses the existing menu to select which Quarkus project to deploy.
Uses OpenShift Connector in order to deploy the Quarkus project to
OpenShift.
OpenShift Connector handles selecting/creating the application and
naming the component.

Closes #313

Signed-off-by: David Thompson [email protected]

datho7561 · 2020-11-03T15:08:07Z

@mohitsuman @dgolovin This is a POC for selecting a Quarkus project to deploy from the current workspace. The next step would be integrating with OpenShift Connector in order to deploy the selected Quarkus project to OpenShift.

src/wizards/deployToOpenShift/deployToOpenShift.ts

datho7561 · 2020-11-10T22:04:35Z

I think this should work now. I don't have access to an OpenShift cluster to test this on, though. I tried with minikube and it looks like that doesn't work.

How to use:

Build and install a .vsix of OpenShift Connector from the master branch on the GitHub
Install the vscode-microprofile extension from your preferred extension marketplace
Follow these instructions to get a development environment for this extension
Build and run this extension
Make a Quarkus project
Open the folder that contains the Quarkus project
Run the "Quarkus: Deploy to OpenShift" command

This should also work for multi root workspaces. There should be a dialog that prompts to select which project to deploy.

fbricon

Didn't work for me:

Maybe it's because I'm running vscode-quarkus from the Extension Development Host? The openshift extension does install though

src/utils/openShiftConnectorUtils.ts

fbricon · 2020-11-13T16:47:27Z

After installing the latest vscode-openshift-tools CI build from https://download.jboss.org/jbosstools/adapters/snapshots/vscode-openshift-tools/?C=M;O=D, without even creating/connecting to an openshift cluster, the deploy command gives me 2 conflicting messages:

@dgolovin if there's no cluster available, we want the deploy command to initiate the creation/configuration of the cluster

src/wizards/deployToOpenShift/deployToOpenShift.ts

datho7561 · 2020-11-13T19:50:41Z

After installing the latest vscode-openshift-tools CI build from https://download.jboss.org/jbosstools/adapters/snapshots/vscode-openshift-tools/?C=M;O=D, without even creating/connecting to an openshift cluster, the deploy command gives me 2 conflicting messages:

I was expecting the command to reject if something goes wrong. If there is a command that returns if there is a cluster or rejects if there is none, I could use that before trying to deploy.

dgolovin · 2020-11-14T02:20:00Z

@datho7561 @fbricon I generated quarkus project, it is using maven. Then I am trying to deploy and get this error: "No quarkus project detected in this folder". How do I set this folder?

src/utils/openShiftConnectorUtils.ts

datho7561 · 2020-11-16T17:22:46Z

@fbricon it looks like the issue dgolovin ran into is related to jdt.ls not automatically importing the project. I'll investigate and open a bug this afternoon.

@dgolovin If you open the project folder (quarkus-getting-started) through Ctrl+K O, it will complete some initial setup that should have been done automatically. Then, if you try the Deploy to OpenShift, it should work.

I'll also ~~open an issue for improving~~ improve the "no projects detected" to better explain which folders it looks through for the Quarkus project.

src/wizards/deployToOpenShift/deployToOpenShift.ts

src/utils/openShiftConnectorUtils.ts

fbricon · 2021-05-05T16:46:10Z

It should be openshift-tools' responsibility to perform the necessary checks for deploying to openshift (stuff involving kubectl for instance). @dgolovin please check what parts of this PR should be moved to openshift tools

src/utils/openShiftConnectorUtils.ts

src/wizards/deployToOpenShift/deployToOpenShift.ts

datho7561 · 2021-05-11T20:02:58Z

Thanks for the review, Denis! I have addressed the comments.

src/utils/openShiftConnectorUtils.ts

datho7561 · 2021-05-27T15:44:58Z

@fbricon This should work properly with the snapshot build of OpenShift Connector 0.2.7

dgolovin · 2021-06-09T05:08:14Z

@datho7561 0.2.7 was released last week.

Uses the existing menu to select which Quarkus project to deploy. Uses OpenShift Connector in order to deploy the Quarkus project to OpenShift. The component is created if it does not exist yet (i.e. no .odo folder is present), and it's pushed if it already exists. OpenShift Connector handles selecting/creating the application and naming the component. Closes redhat-developer#313 Signed-off-by: David Thompson <[email protected]>

mohitsuman · 2021-06-16T08:53:42Z

Hi @datho7561, for this command, do we have any changes for it to be merged ?

datho7561 · 2021-06-16T15:00:18Z

@mohitsuman this PR should be good to merge. I'll merge it now.

datho7561 force-pushed the 313-deploy-to-openshift branch 4 times, most recently from 469ce40 to 9ef087e Compare October 30, 2020 20:29

datho7561 linked an issue Nov 3, 2020 that may be closed by this pull request

Provide a "Deploy to OpenShift" command #313

Closed

dgolovin reviewed Nov 3, 2020

View reviewed changes

src/wizards/deployToOpenShift/deployToOpenShift.ts Outdated Show resolved Hide resolved

datho7561 force-pushed the 313-deploy-to-openshift branch 2 times, most recently from b9171e1 to bf30aac Compare November 10, 2020 21:49

fbricon requested changes Nov 13, 2020

View reviewed changes

src/utils/openShiftConnectorUtils.ts Outdated Show resolved Hide resolved

fbricon reviewed Nov 13, 2020

View reviewed changes

src/utils/openShiftConnectorUtils.ts Outdated Show resolved Hide resolved

fbricon mentioned this pull request Nov 13, 2020

Start the "create an openshift cluster" wizard when calling the Deploy to Openshift command, if necessary redhat-developer/vscode-openshift-tools#1849

Open

fbricon reviewed Nov 13, 2020

View reviewed changes

src/wizards/deployToOpenShift/deployToOpenShift.ts Outdated Show resolved Hide resolved

datho7561 force-pushed the 313-deploy-to-openshift branch 2 times, most recently from 15de542 to a6ded85 Compare November 13, 2020 19:41

dgolovin reviewed Nov 14, 2020

View reviewed changes

src/utils/openShiftConnectorUtils.ts Outdated Show resolved Hide resolved

datho7561 force-pushed the 313-deploy-to-openshift branch 2 times, most recently from 2a3d8db to 8184429 Compare November 17, 2020 16:11

datho7561 force-pushed the 313-deploy-to-openshift branch from 8184429 to e8bd39c Compare December 1, 2020 18:53

datho7561 marked this pull request as ready for review December 1, 2020 18:59

datho7561 commented Dec 2, 2020

View reviewed changes

src/wizards/deployToOpenShift/deployToOpenShift.ts Outdated Show resolved Hide resolved

src/wizards/deployToOpenShift/deployToOpenShift.ts Outdated Show resolved Hide resolved

datho7561 force-pushed the 313-deploy-to-openshift branch from e8bd39c to afe3e25 Compare December 3, 2020 22:20

datho7561 force-pushed the 313-deploy-to-openshift branch 3 times, most recently from bdad270 to 13436f9 Compare March 8, 2021 15:50

datho7561 commented Mar 15, 2021

View reviewed changes

src/wizards/deployToOpenShift/deployToOpenShift.ts Show resolved Hide resolved

datho7561 force-pushed the 313-deploy-to-openshift branch from 570af11 to 0dec4fe Compare March 15, 2021 15:49

datho7561 commented Mar 15, 2021

View reviewed changes

src/utils/openShiftConnectorUtils.ts Outdated Show resolved Hide resolved

datho7561 force-pushed the 313-deploy-to-openshift branch from 0dec4fe to d55d576 Compare March 15, 2021 16:02

datho7561 force-pushed the 313-deploy-to-openshift branch from d55d576 to b951014 Compare May 3, 2021 18:01

mohitsuman mentioned this pull request May 4, 2021

Test and fix Deploy to OpenShift command for Quarkus project redhat-developer/vscode-openshift-tools#2107

Closed

datho7561 force-pushed the 313-deploy-to-openshift branch from b951014 to f3c2aea Compare May 5, 2021 14:39

dgolovin reviewed May 11, 2021

View reviewed changes

datho7561 force-pushed the 313-deploy-to-openshift branch 2 times, most recently from cdcb84f to 8d2bec4 Compare May 11, 2021 19:57

dgolovin reviewed May 13, 2021

View reviewed changes

src/utils/openShiftConnectorUtils.ts Show resolved Hide resolved

datho7561 force-pushed the 313-deploy-to-openshift branch 3 times, most recently from 4f25c20 to ddec3cc Compare May 13, 2021 13:43

fbricon mentioned this pull request May 19, 2021

Let users know they can deploy to openshift #359

Closed

datho7561 force-pushed the 313-deploy-to-openshift branch 2 times, most recently from 507fac2 to e9861ba Compare May 26, 2021 15:17

datho7561 commented May 26, 2021

View reviewed changes

src/utils/openShiftConnectorUtils.ts Outdated Show resolved Hide resolved

datho7561 force-pushed the 313-deploy-to-openshift branch from e9861ba to 72d72f0 Compare May 26, 2021 15:40

datho7561 requested a review from fbricon May 27, 2021 15:44

datho7561 force-pushed the 313-deploy-to-openshift branch from 72d72f0 to 8cc3dac Compare June 9, 2021 13:17

datho7561 merged commit 68dc8f8 into redhat-developer:master Jun 16, 2021

datho7561 deleted the 313-deploy-to-openshift branch June 16, 2021 15:00

Deploy to OpenShift command #316

Deploy to OpenShift command #316

Uh oh!

Conversation

datho7561 commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datho7561 commented Nov 3, 2020

Uh oh!

Uh oh!

datho7561 commented Nov 10, 2020

Uh oh!

fbricon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fbricon commented Nov 13, 2020

Uh oh!

Uh oh!

datho7561 commented Nov 13, 2020

Uh oh!

dgolovin commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

datho7561 commented Nov 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fbricon commented May 5, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

datho7561 commented May 11, 2021

Uh oh!

Uh oh!

Uh oh!

datho7561 commented May 27, 2021

Uh oh!

dgolovin commented Jun 9, 2021

Uh oh!

mohitsuman commented Jun 16, 2021

Uh oh!

datho7561 commented Jun 16, 2021

Uh oh!

Uh oh!

datho7561 commented Oct 30, 2020 •

edited

Loading

dgolovin commented Nov 14, 2020 •

edited

Loading

datho7561 commented Nov 16, 2020 •

edited

Loading