Handle unresolved Sentinel master/replica error #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis-rb#178 introduced a regression that caused a `ConnectionError` to be thrown to the caller if the Sentinel master or replica could not be resolved. When a `ConnectionError` is thrown, the error message handler would attempt to retrieve `config.server_url`, but this in turn causes another Sentinel resolution to be attempted. We avoid this by adding a `resolved?` method that will indicate whether the config can be used. The error handler won't attempt to provide more details if the config has yet to be resolved. Closes redis-rb#182
stanhu
force-pushed
the
sh-fix-unresolved-sentinel-config
branch
from
af20509 to
1322988
Compare
stanhu
changed the title
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#178 introduced a regression that caused a
ConnectionErrorto be thrown to the caller if the Sentinel master or replica could not be resolved.When a
ConnectionErroris thrown, the error message handler would attempt to retrieveconfig.server_url, but this in turn causes another Sentinel resolution to be attempted.We avoid this by adding a
resolved?method that will indicate whether the config can be used. The error handler won't attempt to provide more details if the config has yet to be resolved.Closes #182