Skip to content

DOC-5064 improvements to Jedis production usage advice #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Apr 10, 2025

DOC-5064

I've added four new short sections, partly based on suggestions in Ricardo Ferreira's recent blog post and an experimental "live" checklist. I've also expanded the description of timeouts a bit. All feedback is welcome, as usual, especially regarding the following points:

  • We could also add failover as a recommendation, but it is a common requirement? Might be misleading if we recommend it but most people don't need to use it.
  • I think retries are handled by connection pools but if it's worth explicitly mentioning them then I'll add a specific section.
  • Should TLS connection be a production recommendation, or is it something that people should just add if they need it?

@andy-stark-redis andy-stark-redis requested review from mortensi and a team April 10, 2025 15:02
@andy-stark-redis andy-stark-redis self-assigned this Apr 10, 2025
Copy link
Contributor

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of items to validate. I like the checklist short code! Approving now so you're not held up.

@andy-stark-redis
Copy link
Contributor Author

Well spotted, @dwdougherty - thanks!

@andy-stark-redis andy-stark-redis requested a review from uglide April 22, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants