-
Notifications
You must be signed in to change notification settings - Fork 2.4k
hotfix/v8_conn_pool_check_fd #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh, we neglected to port the PR to v8, thanks for the addition. |
Looks good. Don't forget to remove the Draft label once this is ready. |
…-redis into hotfix/v8_conn_pool_check_fd
That's really bad, so don't you plan to fix this problem in v8? |
Can I add an option to ConnPool(like |
NO, although we lost 20% of performance, 20% performance reduction, in exchange for a stable and effective network connection for us, it is worth it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good 👍🏻
hello, our team hopes to fix this wrong connection problem in v8 and add a tag on this basis
reference mr: #1824