-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add test codes for search_commands.go #3285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @tomfrombayesians , Thanks for your contribution! |
Hello @tomfrombayesians, there is a file |
4316fff
to
cff6483
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Left a suggestion in one of the tests.
Thank you for the contribution, @tomfrombayesians !
Co-authored-by: Nedyalko Dyakov <[email protected]>
fix type in Sprintf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomfrombayesians thank you for your contribution
Hello!
Since this is my first PR, I added a very small test. Our team is developing Tom, an open-source AI agent that automates code maintenance tasks like writing unit tests. This code was created through collaboration between Tom and me.
Right now, our project is still private, but if you’re interested, you can sign up for the Beta Release Waitlist through this link to get notified when it becomes available.
By the way, I ran into an issue when trying to execute the tests as described in the CONTRIBUTE guide. Even after running a Redis server locally and setting the required port, I couldn’t get the full test suite to run properly. To work around this, I created a TestSuite function inside search_commands_test.go to run the Ginkgo test in isolation.
Please let me know if anything needs to be adjusted! Thanks :)