-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Ensure context isn't exhausted via concurrent query as opposed to sentinel query #3334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6f22bf5
bug: ensure context isn't exhausted via concurrent query
gnpaone 6ec0cfd
Update sentinel.go
gnpaone 9b40ce4
Merge branch 'master' into patch-1
ndyakov 1601768
Remove separate goroutine and just wait on the main WaitGroup
gnpaone 84b2016
Need to immediately return in context canceled or deadline exceeded c…
gnpaone d231fa0
Add test for proper sentinel resolution
gnpaone 6d78214
Stop goroutines early after success is achieved
gnpaone bd27395
Update sentinel_test.go
gnpaone 7ab8412
Merge branch 'master' into patch-1
ndyakov 0f05272
Merge branch 'master' into patch-1
gnpaone 173d598
Merge branch 'master' into patch-1
ndyakov 67fe50d
Merge branch 'master' into patch-1
ndyakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.