Skip to content

Add support for WAITAOF command #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2023
Merged

Conversation

gniadeck
Copy link
Contributor

@gniadeck gniadeck commented May 7, 2023

No description provided.

@gniadeck gniadeck marked this pull request as ready for review May 7, 2023 13:06
@sazzad16 sazzad16 linked an issue May 7, 2023 that may be closed by this pull request
@sazzad16 sazzad16 requested a review from yangbodong22011 May 7, 2023 15:47
@sazzad16 sazzad16 changed the title #3344 Add support for new redis command WAITAOF Add support for WAITAOF command May 7, 2023
@sazzad16 sazzad16 added this to the 4.4.0 milestone May 7, 2023
@sazzad16 sazzad16 modified the milestones: 4.4.0, 4.5.0 May 8, 2023
yangbodong22011
yangbodong22011 previously approved these changes May 8, 2023
Copy link
Contributor

@yangbodong22011 yangbodong22011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sazzad16
sazzad16 previously approved these changes May 8, 2023
@sazzad16 sazzad16 dismissed stale reviews from yangbodong22011 and themself via c0587df May 8, 2023 13:58
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Patch coverage: 40.90% and project coverage change: -0.03 ⚠️

Comparison is base (a916994) 67.26% compared to head (84b0d52) 67.23%.

❗ Current head 84b0d52 differs from pull request most recent head 03210d1. Consider uploading reports for the commit 03210d1 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3393      +/-   ##
============================================
- Coverage     67.26%   67.23%   -0.03%     
- Complexity     4730     4734       +4     
============================================
  Files           269      269              
  Lines         15274    15295      +21     
  Branches        964      965       +1     
============================================
+ Hits          10274    10284      +10     
- Misses         4582     4593      +11     
  Partials        418      418              
Impacted Files Coverage Δ
...ava/redis/clients/jedis/ClusterCommandObjects.java 17.24% <0.00%> (-0.62%) ⬇️
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.48% <0.00%> (-0.05%) ⬇️
...ava/redis/clients/jedis/ShardedCommandObjects.java 20.58% <0.00%> (-0.63%) ⬇️
...main/java/redis/clients/jedis/TransactionBase.java 11.80% <0.00%> (-0.03%) ⬇️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 74.12% <0.00%> (-0.15%) ⬇️
.../main/java/redis/clients/jedis/CommandObjects.java 84.71% <33.33%> (-0.12%) ⬇️
src/main/java/redis/clients/jedis/Pipeline.java 17.07% <33.33%> (+0.05%) ⬆️
.../main/java/redis/clients/jedis/BuilderFactory.java 74.76% <75.00%> (+<0.01%) ⬆️
src/main/java/redis/clients/jedis/Jedis.java 84.78% <100.00%> (+0.02%) ⬆️
src/main/java/redis/clients/jedis/Protocol.java 90.74% <100.00%> (+1.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 force-pushed the 3344/waitaof-support branch from c0587df to 03210d1 Compare May 8, 2023 14:10
@sazzad16 sazzad16 merged commit 8a5740d into redis:master May 8, 2023
@sazzad16 sazzad16 modified the milestones: 4.4.x, 4.4.1 Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new redis command WAITAOF
4 participants