Skip to content

Use a Standard-Compliant License Identifier #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2015

Conversation

kemitchell
Copy link
Contributor

This pull request changes the value of the license property in package.json to a standard, machine-readable SPDX license identifier.

I'll be honest: This is a semi-automated pull request. I started by using dat and dat-npm to review metadata for all packages on npm, looking for packages that don't use a valid SPDX license identifier in package.json. I used my own npm module, spdx-correct to guess what license you were after: "MIT". A quick manual check and a few shell scripts later, and this pull request was born.

npm doesn't require that you use a valid SPDX identifier, but it's strongly recommended. (Try npm help 7 package.json and search for “License”.) Other source code package managers, like Maven for Java and RubyGems for Ruby, recommend the same.

Why care about SPDX? A machine-readable standard makes it possible for programs, rather than just people, to review a module or even an entire codebase to make sure that licenses are compatible. Whatever the reason—strong personal conviction, company policy, terms of a business deal—SPDX makes it easier to collaborate with others when licenses can be a problem, and helps take open-source software to more places. Given that npm has a ton of modules but also handles dependencies in a novel way, I think a little license hygiene could help npm build amazing new relationships between communities that lawyers have long kept apart.

Though this PR was semi-automated, my responses to any questions you have won't be. I can't give legal advice via GitHub, but I'm happy to answer questions about SPDX or point you to good resources.

Thanks for your contribution to open-source software!

K

@phated
Copy link

phated commented May 19, 2015

👍

@kemitchell
Copy link
Contributor Author

@phated, thanks! Still feel a little sheepish about sending automatic PRs, but so far response has been almost entirely positive.

This is one of the 1,000 most-depended-upon packages on npm, a little over half of which don't have compliant license metadata. Landing the patch would let us automate the license check for lots of people!

@raydog
Copy link
Contributor

raydog commented Jul 11, 2015

This PR totally makes sense.

raydog added a commit that referenced this pull request Jul 11, 2015
Use a Standard-Compliant License Identifier
@raydog raydog merged commit e2e790b into redis:master Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants