Skip to content

adds coverage reporting using nyc bin #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2015
Merged

adds coverage reporting using nyc bin #758

merged 1 commit into from
Jul 11, 2015

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 25, 2015

This pull request adds coverage reporting using nyc:

  • run npm run coverage to get a human readable coverage report.
  • run npm run coverage -- --reporter=lcov to get an HTML report over coverage in the /coverage folder.

Here's what the output looks like:

--------------------|-----------|-----------|-----------|-----------|
File                |   % Stmts |% Branches |   % Funcs |   % Lines |
--------------------|-----------|-----------|-----------|-----------|
   ./               |     82.34 |     75.97 |        80 |     82.52 |
      index.js      |     82.77 |     76.42 |     81.01 |     82.72 |
      test-unref.js |     54.55 |        50 |         0 |     66.67 |
   ./lib/           |     79.07 |        70 |     85.71 |     79.07 |
      commands.js   |       100 |       100 |       100 |       100 |
      queue.js      |     74.19 |        70 |     83.33 |     74.19 |
      to_array.js   |       100 |       100 |       100 |       100 |
      util.js       |        80 |       100 |       100 |        80 |
   ./lib/parser/    |     78.26 |     72.62 |        75 |     78.26 |
      hiredis.js    |         8 |         0 |         0 |         8 |
      javascript.js |     89.31 |     82.43 |     92.31 |     89.31 |
--------------------|-----------|-----------|-----------|-----------|
All files           |      81.4 |     75.36 |     79.61 |     81.53 |
--------------------|-----------|-----------|-----------|-----------|

@bcoe
Copy link
Contributor Author

bcoe commented Jul 11, 2015

@raydog @brycebaril any objection to my updating this to a recent version of nyc, and adding coverage reporting to node_redis?

@raydog
Copy link
Contributor

raydog commented Jul 11, 2015

👍 This is cool. I actually didn't know about nyc. I always just used istanbul directly...

raydog added a commit that referenced this pull request Jul 11, 2015
adds coverage reporting using nyc bin
@raydog raydog merged commit 9b02ae6 into redis:master Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants