Add RESP2 to RESP3 replies migration guide #2513
Open
+120
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for redis-doc pending review.Visit the deploys page to approve it
|
itamarhaber
reviewed
Aug 11, 2023
mgravell
reviewed
Aug 11, 2023
oranagra
reviewed
Aug 13, 2023
|
I believe there may be some more "verbatim string" swaps; |
21 tasks
|
To @mgravell's point - |
|
@mgravell @slorello89 @oranagra Sorry for the delay. The document was updated. |
slorello89
approved these changes
Sep 5, 2023
NickCraver
added a commit
to StackExchange/StackExchange.Redis
that referenced
this pull request
Sep 7, 2023
Overall changes:
- [x] introduce `Resp2Type` and `Resp3Type` shims (`Resp2Type` has reduced types); existing code using `[Obsolete] Type` uses `Resp2Type` for minimal code impact
- [x] mark existing `Type` as `[Obsolete]`, and proxy to `Resp2Type` for compat
- [x] deal with null handling differences
- [x] deal with `Boolean`, which works very differently (`t`/`f` instead of `1`/`0`)
- [x] deal with `[+|-]{inf|nan}` when parsing doubles (explicitly called out in the RESP3 spec)
- [x] parse new tokens
- [x] `HELLO` handshake
- [x] core message and result handling
- [x] validation and fallback
- [x] prove all return types (see: redis/redis-specifications#15)
- [x] <strike>streamed RESP3</strike> omitting; not implemented by server; can revisit
- [x] deal with pub/sub differences
- [x] check routing of publish etc
- [x] check re-wire of subscription if failed
- [x] check receive notifications
- [x] connection management (i.e. not to spin up in resp3)
- [x] connection fallback spinup (i.e. if we were trying resp3 but failed)
- [x] other
- [x] [undocumented RESP3 delta](redis/redis-doc#2513)
- [x] run core tests in both RESP2 and RESP3
- [x] compensate for tests that expect separate subscription connections
Co-authored-by: Nick Craver <[email protected]>
Co-authored-by: Nick Craver <[email protected]>
dwdougherty
requested changes
Dec 19, 2023
Co-authored-by: David Dougherty <[email protected]>
|
|
|
just wondering... any plans to merge this ever? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2511 for more details.