Skip to content

Add python_requires setuptools check for python > 3.6 #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

Nicusor97
Copy link
Contributor

@Nicusor97 Nicusor97 commented Oct 27, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

I noticed that in your latest release candidate version 4.0.0b3 the Python 2.7 support has been removed but your forgot to add the python_requires check that will prevent users with Python 2.7 from downloading a sdist version that they cannot build on Python 2.7.

Note: supporting python_requires requires setuptools>=24.2.0 and pip>=9.0.0 to benefit from it.
Details here: https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires

I open this MR in order to merge the python_requires before releasing the official version because if the official version will not have this check, the Python 2 users will not be able to build the sdist and in the end that new version should be yanked and release a new version with the python_requires check.

@chayim
Copy link
Contributor

chayim commented Oct 27, 2021

Thanks a tonne! I've transitioned all of my other packages to poetry - and this literally slipped my mind. It's been a few years since I've touched a setup.py

This is an awesome change. Thank you so much! In fact, the more you know about setup.py the better :)

@chayim chayim added breakingchange API or Breaking Change bug Bug labels Oct 27, 2021
@chayim chayim changed the title fix: add python_requires setuptools check Add python_requires setuptools check for python > 3.6 Oct 27, 2021
@chayim chayim merged commit 992b149 into redis:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants