Skip to content

Search alias test fix #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Search alias test fix #1695

merged 3 commits into from
Nov 10, 2021

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Nov 10, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

fixes #1690

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #1695 (32b8406) into master (f5160f5) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
+ Coverage   89.71%   89.80%   +0.09%     
==========================================
  Files          57       57              
  Lines       11186    11243      +57     
==========================================
+ Hits        10035    10097      +62     
+ Misses       1151     1146       -5     
Impacted Files Coverage Δ
tests/test_search.py 98.85% <100.00%> (+0.83%) ⬆️
tests/test_json.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5160f5...32b8406. Read the comment docs.

@chayim
Copy link
Contributor

chayim commented Nov 10, 2021

I think this works. I re-ran the job several times and haven't seen the failure. Thanks @ashtul !!

@chayim chayim merged commit 776dd59 into redis:master Nov 10, 2021
@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 14, 2021
@chayim chayim changed the title [TEST] search alias test Search alias test fix Nov 14, 2021
@ashtul ashtul deleted the fix-alias-test branch April 6, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permanent Fix for Flaky Unit Test
3 participants