Skip to content

FT.EXPLAINCLI intentionally raising NotImplementedError #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2021
Merged

FT.EXPLAINCLI intentionally raising NotImplementedError #1705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a3b305
FT.EXPLAINCLI intentionally raising NotImplementedError
chayim Nov 14, 2021
b45ce0a
flake8
chayim Nov 14, 2021
8dfd9ba
Merge remote-tracking branch 'origin/master' into ck-explaincli
chayim Nov 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions redis/commands/search/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
ADDHASH_CMD = "FT.ADDHASH"
DROP_CMD = "FT.DROP"
EXPLAIN_CMD = "FT.EXPLAIN"
EXPLAINCLI_CMD = "FT.EXPLAINCLI"
DEL_CMD = "FT.DEL"
AGGREGATE_CMD = "FT.AGGREGATE"
CURSOR_CMD = "FT.CURSOR"
Expand Down Expand Up @@ -376,6 +377,9 @@ def explain(self, query):
args, query_text = self._mk_query_args(query)
return self.execute_command(EXPLAIN_CMD, *args)

def explain_cli(self, query): # noqa
raise NotImplementedError("EXPLAINCLI will not be implemented.")

def aggregate(self, query):
"""
Issue an aggregation query
Expand Down
6 changes: 6 additions & 0 deletions tests/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,12 @@ def test_explain(client):
assert res


@pytest.mark.redismod
def test_explaincli(client):
with pytest.raises(NotImplementedError):
client.ft().explain_cli("foo")


@pytest.mark.redismod
def test_summarize(client):
createIndex(client.ft())
Expand Down