Skip to content

Add support for ZMPOP #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Add support for ZMPOP #1852

wants to merge 14 commits into from

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 4, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1846

@dvora-h dvora-h added the feature New feature label Jan 4, 2022
@dvora-h dvora-h requested a review from chayim January 4, 2022 10:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #1852 (8a6acc2) into master (15f315a) will increase coverage by 0.05%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   93.60%   93.65%   +0.05%     
==========================================
  Files          76       76              
  Lines       16214    16288      +74     
==========================================
+ Hits        15177    15255      +78     
+ Misses       1037     1033       -4     
Impacted Files Coverage Δ
redis/cluster.py 92.42% <ø> (+0.37%) ⬆️
redis/commands/graph/commands.py 84.50% <ø> (ø)
setup.py 0.00% <ø> (ø)
tests/test_cluster.py 98.28% <75.00%> (-0.25%) ⬇️
redis/commands/search/commands.py 89.07% <93.75%> (+0.61%) ⬆️
redis/commands/core.py 90.01% <100.00%> (+0.07%) ⬆️
redis/commands/parser.py 90.32% <100.00%> (+1.61%) ⬆️
redis/connection.py 88.33% <100.00%> (ø)
tests/test_commands.py 99.39% <100.00%> (+<0.01%) ⬆️
tests/test_search.py 99.07% <100.00%> (+0.05%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f315a...8a6acc2. Read the comment docs.

@chayim chayim added the redis-7 label Jan 4, 2022
@chayim chayim self-assigned this Jan 4, 2022
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvora-h dvora-h requested a review from chayim January 13, 2022 12:38
@dvora-h dvora-h closed this Feb 2, 2022
@dvora-h
Copy link
Collaborator Author

dvora-h commented Feb 2, 2022

Done in #1923

@dvora-h dvora-h deleted the add-zmpop branch February 2, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ZMPOP
9 participants