Skip to content

Added Redis 8.0 to test matrix #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 21, 2025
Merged

Added Redis 8.0 to test matrix #3469

merged 10 commits into from
Jan 21, 2025

Conversation

vladvildanov
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@vladvildanov vladvildanov added the breakingchange API or Breaking Change label Jan 14, 2025
uglide
uglide requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes are required. See my inline comments

uglide
uglide reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment

uglide
uglide approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladvildanov vladvildanov merged commit b2dd8e8 into master Jan 21, 2025
39 checks passed
@vladvildanov vladvildanov deleted the vv-test-8.0 branch January 21, 2025 09:24
@petyaslavova petyaslavova mentioned this pull request Feb 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uglide uglide uglide approved these changes

@dmaier-redislabs dmaier-redislabs Awaiting requested review from dmaier-redislabs dmaier-redislabs is a code owner

Assignees
No one assigned
Labels
breakingchange API or Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladvildanov @uglide