-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Change type hints with possible None args or return types to be annotated with Optional - includes commands in core.py and json commands #3610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4255e10
fix(redis-client): change `zrange` num parameter type to `Optional[int]`
kesha1225 393f260
add changes
kesha1225 54f3573
fix(redis-client): normalize optional parameter annotations
kesha1225 fc88d6f
Merge branch 'master' into fix-type
petyaslavova 339d180
commit message: fix(redis-client): normalize optional parameter annot…
kesha1225 8df197c
fix(redis-client): replace Optional[None] with Optional[int] for nume…
kesha1225 f33afac
fix: typo
kesha1225 245b6b8
Merge branch 'master' into fix-type
petyaslavova 6f3127f
Merge branch 'master' into fix-type
petyaslavova 7ee3bf2
commit message: fix(redis-client): fix broken types
kesha1225 4a7216b
commit message: fix(redis-client): fix broken types
kesha1225 87c07fc
commit message: fix(redis-client): fix broken types
kesha1225 b95574b
Merge branch 'master' into fix-type
petyaslavova 33d5fdb
Merge branch 'master' into fix-type
petyaslavova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.