Skip to content

Updating default retry strategy for standalone clients. 3 retries with ExponentialWithJitterBackoff become the default config. #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

petyaslavova
Copy link
Collaborator

@petyaslavova petyaslavova commented Apr 23, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Updating default retry strategy for standalone clients.
3 retries with ExponentialWithJitterBackoff become the default config.

The default retry configuration for the sync and async standalone clients are affected.

This change affects the cluster nodes Redis clients so when those clients are created a retry object with 0 retries and default back off strategy is provided (this is already the default behavior, so there are no code changes related to that one).

@petyaslavova petyaslavova force-pushed the ps_change_default_retry_config_for_standalone_clients branch from 76d547e to 5707a13 Compare April 23, 2025 15:45
@petyaslavova petyaslavova force-pushed the ps_change_default_retry_config_for_standalone_clients branch from 5707a13 to e2143dc Compare April 24, 2025 15:08
@vladvildanov vladvildanov added the breakingchange API or Breaking Change label Apr 28, 2025
@petyaslavova petyaslavova merged commit f32a1ca into master Apr 28, 2025
37 checks passed
@petyaslavova petyaslavova deleted the ps_change_default_retry_config_for_standalone_clients branch April 28, 2025 15:22
petyaslavova added a commit that referenced this pull request Apr 29, 2025
…h ExponentialWithJitterBackoff become the default config. (#3614)

* Changing the default retry configuration for Redis standalone clients.

* Updating default retry strategy for standalone clients. 3 retries with ExponentialWithJitterBackoff become the default config.

* Applying review comments - removing unused methods from retry objects, updating pydocs of error handler method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants