When SlotNotCoveredError is raised, the cluster topology should be reinitialized as part of error handling and retrying of the commands. #3621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initialized as part of error handling and retrying of the commands.
vladvildanov
approved these changes
Apr 29, 2025
petyaslavova
added a commit
that referenced
this pull request
Apr 29, 2025
…initialized as part of error handling and retrying of the commands. (#3621)
petyaslavova
added a commit
that referenced
this pull request
Apr 29, 2025
…initialized as part of error handling and retrying of the commands. (#3621)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixes issue #3620
When we are handling different errors, we run cluster reinitialization that calls CLUSTER SLOTS.
Sometimes the cluster slots temporarily might not be fully covered and if we try to execute a command against key from the missing slots we receive SlotNotCoveredError.
The problem is that after this error appears we don't try to reinitialize again the slots and the Cluster client can't heal itself.
With this change I'm adding error handling for the SlotNotCoveredError, the same way we handle ClusterDownErrors - try to extract the slots coverage after a little sleep.