Fixes subscription bug when a new store is passed as a prop.

[jimbolla]

Reported here: davidkpiano/react-redux-form#592

[davidkpiano]

Thanks @jimbolla - the general idea is that this should work:

// overly simplified for clarity

<Provider store={store}>
  <Foo>
    <Bar store={ownStore} />
  </Foo>
</Provider>

If I'm not mistaken, <Bar> should subscribe to its ownStore as if it were its own <Provider> (because it essentially is) instead of depending on parent subscriptions.

[jimbolla]

Correct. I think there's an edge case to this edge case I'm not covering so I'm gonna keep working on it, but this should be better.

[jimbolla]

OK. Now I think I covered the edge cases correctly.

[jimbolla]

@timdorr Thoughts on pushing a patch release for this and the other handful of fixes we have waiting to go out?

[davidkpiano]

Any updates on this? Will it be able to be merged in soon? 🙏

[markerikson]

@jimbolla , @timdorr : following up on this at @davidkpiano 's request. It's Jim's code thus far, and Tim's been cutting releases (something I should go figure out for myself at some point, but don't have time to dig into atm). Are we good to go on this?

[timdorr]

I haven't had time to really dig into this one. It's a non-trivial change, hence the hesitation to just blindly merge it in. If anyone else wants to review, I trust them to point out any problems.

[markerikson]

Yeah, that's actually how I feel about this myself at the moment :)

[jimbolla]

@timdorr @markerikson It might be easier to review the 2 commits separately. The bugfix one is pretty small and the refactor one just moves a few things and adds some more comments.

[timdorr]

OK, LGTM. In the future, I'd submit refactors as either separate PRs or just directly onto master.

[anru]

@timdorr please release this fix

[BerndWessels]

@timdorr The react-redux 5.0.3 update breaks HMR with latest react-hot-loader 3.0.0-beta.6.

Basically after a hot-reload the state is somehow broken.

This worked fine in react-redux 5.0.2 :(

repo to reproduce: https://github.com/BerndWessels/react-redux-rr4-wp2-rhl3.git

Work fine with react-redux 5.0.2 but broken when you upgrade to react-redux 5.0.3