Skip to content

Drop support for React 0.13 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2015
Merged

Drop support for React 0.13 #71

merged 3 commits into from
Oct 15, 2015

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Aug 24, 2015

We won't do this yet, but React 0.14 makes everything simpler for us.
When it's out, releasing this will be a breaking change.

Changes:

  • No more support for function inside <Provider>, as we have parent context in 0.14
  • No more jumping through hoops to support React Native: we can still import React from 'react'
  • We can put react in peerDependencies now because it will work for React Native, and also won't cause “duplicate React” issues
  • With React Native 0.10, we can rely on process.env.NODE_ENV polyfill being there

Checklist:

  • Drop support for React 0.13 in a branch
  • Wait for React 0.14
  • Wait for React Native 0.10 (will it use 0.14?)
  • Update the docs
  • Merge and release as a breaking change

@gaearon gaearon force-pushed the drop-react-0.13-support branch from 5517ddc to 2cc858c Compare August 24, 2015 18:23
@gnoff
Copy link
Contributor

gnoff commented Aug 24, 2015

What is the impetus from switching for a creator pattern to directly exporting the two components?

@gaearon
Copy link
Contributor Author

gaearon commented Aug 25, 2015

What is the impetus from switching for a creator pattern to directly exporting the two components?

The reason a factory was added in the first place is because we either needed React from react or from react-native, depending on what user wanted, and couldn't express this statically. With 0.14 we can just use react because react-native will just be a renderer like react-dom, and won't contain Component, PropTypes, etc.

@gaearon
Copy link
Contributor Author

gaearon commented Oct 7, 2015

Updated this.

@cwbutler
Copy link

Still waiting on React Native?

@gaearon
Copy link
Contributor Author

gaearon commented Oct 12, 2015

Not really—we'll just ask RN users to stay on previous major. I'll release this soon.

@gaearon gaearon force-pushed the drop-react-0.13-support branch 2 times, most recently from 651f2b9 to a8778b3 Compare October 15, 2015 10:20
@gaearon gaearon force-pushed the drop-react-0.13-support branch from a8778b3 to c54ffd9 Compare October 15, 2015 10:42
@gaearon gaearon force-pushed the drop-react-0.13-support branch from 33ae3ef to 3ee376a Compare October 15, 2015 12:09
@gaearon gaearon force-pushed the drop-react-0.13-support branch from 3ee376a to 11dee1f Compare October 15, 2015 12:15
@gaearon gaearon changed the title (Do not merge!) Drop support for React 0.13 Drop support for React 0.13 Oct 15, 2015
gaearon added a commit that referenced this pull request Oct 15, 2015
@gaearon gaearon merged commit 084cedb into master Oct 15, 2015
@gaearon gaearon deleted the drop-react-0.13-support branch October 15, 2015 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants