subscribe moved from Connector constructor to componentDidMount #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,10 +38,14 @@ export default function createConnector(React) { | |||
| constructor(props, context) { | |||
| super(props, context); | |||
|
|
|||
| this.unsubscribe = context.redux.subscribe(::this.handleChange); | |||
| this.redux = context.redux; | |||
There was a problem hiding this comment.
You don't have to to this (see below)
|
ok, thanks makes sense, I've modified as suggested |
|
Can you please add a unit test verifying this change, and then squash the commits into a single commit? Thanks. |
access redux instance from this.context test added
|
@gaearon added unit test and squashed, very new to this, forgive me. Let me know if I need to change anything |
gaearon
added a commit
that referenced
this pull request
Jun 26, 2015
subscribe moved from Connector constructor to componentDidMount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You shouldn't need to attach the Connector components to redux's setState call unless the component mounts which should only be on the browser side. This will provide more flexibility in the way people decide to do server rendering because componentDidMount is not called on the server.