Documentation for UsageWithReactRouter.md #1929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnctaing
changed the title
|
Wow, this is so good. Thanks for stepping up and actually doing it. |
|
|
||
| ## Redux-router, react-router-redux, react-router | ||
| Before starting, let's clarify the different routing libraries. | ||
|
|
There was a problem hiding this comment.
Let's add a section on React Router first and make it clear you can use it directly with Redux just fine. Many people don't realize this.
There was a problem hiding this comment.
In fact I’d like to completely deemphasize these other libraries here and maybe add them as a footnote. Let’s focus on RR instead.
added 9 commits
September 4, 2016 02:51
… tag, use PascalCase in configuration part titles
| So you want to do routing with your Redux app. You can use it with [React Router](https://github.com/reactjs/react-router). Redux will be the source of truth for your data and React Router will be the source of truth for your URL. In most of the cases, **it is fine** to have them separate unless if you need to time travel and rewind actions that triggers the change URL. | ||
|
|
||
| ## Installing React Router | ||
| `react-router` is available on npm : |
There was a problem hiding this comment.
Let's call it React Router here too.
Please remove space before colon.
added 6 commits
September 4, 2016 17:12
…create-react-app header
…press.js' > 'Express', 'Webpack Dev Server' > 'WebpackDevServer'
|
This is great! I'm going to merge in now. If any other changes are needed, @vnctaing can do a follow-up PR. I'll get this published on the docs site in a second... |
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
* Documentation : first draft for UsageWithReactRouter.md * uses React Router in writting, emphazises React Router in the introduction * transforms title to CamelCase * changes 'back-end' to 'development server', adds missing backticks * adds extension .js to title, fix grammar * adds missing semi-colons in code examples, adds space on self-closing tag, use PascalCase in configuration part titles * fix grammar on 'the todo list is not filtered' * fix innacurate information about Provider and Router relationship * adds a Next Steps section, adds a foot note about other routing libraries * clarifies 'the Router' > 'React Router' * mentions react-router package version * precises description in fallback url * rephrase in more concrete way the fallback URL configuration, adjust create-react-app header * uses 'url'> 'URL' * explains in a more conversational way how bind with React Router, 'Express.js' > 'Express', 'Webpack Dev Server' > 'WebpackDevServer' * fix grammar * removes space before colon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I saw that there were no documentation yet for React-router(#1919). So I tried to create documentation following Dan's series on Egghead.io
Do we have to create an example to
/examplesfor this chapter ?This is my first significant PR to OSS, there are probably unclear explanations or mistakes in my PR I apologize for that I am still a junior dev.
How can I make my PR better ?
Thanks