Add new links to Code Structure #2494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
You can make the link text whatever you want. If there's a more apt description, go ahead and change it to that. |
|
@timdorr thank you for the quick response! I changed link names. Do you think these new ones are ok? |
|
LGTM. Thanks! |
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
* Add new links to Code Structure * Change link description * Change discussion description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new links to "Code Structure" FAQ section (#1785)
I have a question regarding labels for the links, sorry if this question sounds stupid 😸
I looked through the docs and it seems that link labels are always just article/issue name. But in case of issue #384, the actual ticket is more about a naming convention but the comment is about how code structure affects time travel in devtools. Should this be mentioned in link label somehow?