Skip to content

Update to Babel 7 #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update to Babel 7 #2550

wants to merge 1 commit into from

Conversation

hzoo
Copy link

@hzoo hzoo commented Aug 9, 2017

If y'all don't want to upgrade now that's ok, just a test PR then.

Could also change the explicit plugins in favor of https://github.com/babel/babel-preset-env with the exclude option?

    "check-es2015-constants",
    "transform-es2015-arrow-functions",
    "transform-es2015-block-scoped-functions",
    "transform-es2015-block-scoping",
    ["transform-es2015-classes", { "loose": true }],
    ["transform-es2015-computed-properties", { "loose": true }],
    ["transform-es2015-destructuring", { "loose": true }],
    ["transform-es2015-for-of", { "loose": true }],
    "transform-es2015-function-name",
    "transform-es2015-literals",
    "transform-es2015-object-super",
    "transform-es2015-parameters",
    "transform-es2015-shorthand-properties",
    ["transform-es2015-spread", { "loose": true }],
    "transform-es2015-sticky-regex",
    ["transform-es2015-template-literals", { "loose": true }],
    "transform-es2015-unicode-regex",

    // exclude
    "transform-es2015-duplicate-keys"
    "transform-es2015-typeof-symbol"
    "transform-regenerator"
    "transform-exponentiation-operator"
    "transform-async-to-generator"
    "syntax-trailing-function-commas"

    "transform-object-rest-spread",
    "transform-es3-member-expression-literals",
    "transform-es3-property-literals"

@hzoo
Copy link
Author

hzoo commented Aug 9, 2017

Hmm failure is due to using an old version of traverse (some dep isn't updated, maybe cache issue)

@timdorr
Copy link
Member

timdorr commented Aug 9, 2017

I assume we'd want to wait for at least the beta. Any rough schedule for release?

@timdorr
Copy link
Member

timdorr commented Aug 9, 2017

Also see the last time we updated: #1347

I don't think the explicit transforms are necessary anymore. Although, if we want to target a specific browser/node version, we should only update that on the next branch.

@hzoo
Copy link
Author

hzoo commented Aug 9, 2017

@timdorr just fyi alpha shouldn't be any different in the beta for most projects unless you use something custom - https://github.com/babel/babel/milestone/9 need to review 2 prs. We can still run all the transforms.

Oh didn't know about the next branch

@timdorr
Copy link
Member

timdorr commented Aug 9, 2017

No worries. I'm happy to merge this in on the master branch, as long as the same targets (IE8, I think?) are supported. We can move up to IE11 in the next major.

@hzoo
Copy link
Author

hzoo commented Aug 9, 2017

Yeah was my intention to keep it the same, just whether we wanted to use the same plugins or do it via preset-env

@timdorr
Copy link
Member

timdorr commented Oct 22, 2017

@hzoo I'm going to close this out for now, since it's just version bumps. Once 7.0 goes rc or final, I can look into re-opening or making a new PR. We can also finally get on preset-env! 👍 Thanks for looking into this and good luck on the path to 7.0.0!

@timdorr timdorr closed this Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants