Skip to content

Adding Further Information links for the "Structuring Reducers" section #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Adding Further Information links for the "Structuring Reducers" section #2670

wants to merge 2 commits into from

Conversation

renatoselenica
Copy link

@renatoselenica renatoselenica commented Oct 21, 2017

I have added some links to the end of the Basic Reducer Structure Page. I just committed that single page for now to see if this is what you had in mind and if I am doing it ok.

I have used a few links from the ''Prerequisite Concepts" page and added a few from the links in your React/Redux links list.

I wanted to ask if maybe the same link could be in two different pages of the doc, for maybe people who are just looking at a specific page? For example having the same link in "Basic Reducer Structure" and "Splitting Reducer Logic", for something that expands on both.

Also I wanted to ask if I should do one commit for every page on the "Structuring Reducers" section?

P.s. Sorry I am late on this. Stuff in life happened

Fixes #2589

@markerikson
Copy link
Contributor

markerikson commented Oct 21, 2017

No worries, and thanks for working on this!

Yes, I'm fine with having the same link show up in multiple pages if it's relevant. And sure, one commit per page is fine, and go ahead and those commits to this PR so we get them in together.

The formatting looks fine, but I'll suggest a couple changes to the links. I don't think the "Currying Reducers" article is very helpful here, and I think the "Higher Order Reducer" links would be more helpful in a couple of the later pages (especially "Reusing Reducer Logic").

The "Redux Architecture Guidelines" link fits well here because of that section on state shape. I'd also suggest adding James K Nelson's post The 5 Types of React Application State here.

@renatoselenica
Copy link
Author

Ok I am doing the fixes on this page and also I will keeping everything on this PR.

@timdorr
Copy link
Member

timdorr commented Feb 15, 2018

Closing due to inactivity.

@timdorr timdorr closed this Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants