Remove minified check #4445
Closed
Remove minified check #4445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move miniKindOf out of if scope to fix ES5 compatibility issue
- Updated `createStore`'s doc description to mark it as `@deprecated`, so that it shows up with a visual strikethrough in editors. - Added new descriptive text to `createStore` to encourage users to migrate to RTK, and pointing to the "RTK is Redux Today" docs page - Rewrote TS typedefs for `createStore` to define it as a function with overloads, rather than a varible, to get correct docs tooltips when hovering over variable usages - Added `legacy_createStore` API as an alias without the deprecation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9909f77:
|
|
Thanks for the fix! When could we expect this to be released? |
|
There's a couple issues:
|
|
redoing |
✅ Deploy Preview for redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4443
Thanks for the PR!
To better assist you, please select the type of PR you want to create.
Click the "Preview" tab above, and click on the link for the PR type: