This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Add '| undefined' to optional properties #494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #447, adding
| undefined
to all optional property types. Previously considered only updating input types (see #491 and #492), but after more consideration it seems that updating all optional types is safer and guarantees consumers don't run into issues however they choose to use the generated types. This also represents the most targeted changeset after learning a lot about the repo and TS factory types in the earlier versions.See the snapshot to visualize the changes to the generated types. This change will be invisible to consumers who don't have
exactOptionalPropertyTypes
enabled, asfoo?: Bar
is already equivalent tofoo?: Bar | undefined
for them.Also:
exactOptionalPropertyTypes
in this repo (and a few associated type updates)State.generatedInputObjectTypes
(found while working ingenerateInputObjectTypes
in Add '| undefined' to optional input properties (option 1) #491)mutaion
instead ofmutation
ts.factory.createLiteralTypeNode(ts.factory.createToken(ts.SyntaxKind.NullKeyword))
withts.factory.createNull()