inherit paths from parent routes

[ryanflorence]

With the introduction of DefaultRoute and NotFoundRoute I think we need to start inheriting the parent routes.

Both of these new components inherit their parent route in one way or another. As I've been writing the docs and coming up with examples it now feels awkward that normal routes don't get their parent's route. It makes the route config less intuitive than I think it could be.

My proposal is simple and follows HTML precedent:

1. paths that start with / are absolute and work the way they do today
2. all others are relative
3. assumed paths from names would be relative, duplicates should throw (maybe we would already)

A potential route config would look like:

<Routes location="history">
  <Route name="courses" handler={Courses}>
    <!-- note the absolute path for course -->
    <Route name="course" path="/course/:courseId" handler={Course}>
      <!-- full path is `/course/:courseId/announcements`, inherits parent -->
      <Route name="announcements" handler={Announcements} />
      <!-- full path is `/course/:courseId`, inherits parent -->
      <DefaultRoute handler={CourseDashboard} />
      <!-- full path is `/course/:courseId/*`, inherits parent -->
      <NotFoundRoute handler={CoursePathNotFound} />
    </Route>
  </Route>
</Routes>

So ... yeah ... If <Route/> can't inherit the parent, it makes understanding the relationship that DefaultRoute and NotFoundRoute have with the parent more difficult, its also pretty convenient and what you want most of the time.

[mjackson]

Ya. I think I'm in agreement here. 🐬

[ryanflorence]

I've almost got a branch ready

[ryanflorence]

I just realized it also gives meaning to nested <Redirect/>s

[mjackson]

uhoh. I'm working in the exact same portion of the code right now. Trying to make it possible for <DefaultRoute> to have a name prop.

[ryanflorence]

they don't need a name, you redirect/transition/link to the parent.

[mjackson]

There's a small conflict. I'll fix it.

[mjackson]

you redirect/transition/link to the parent.

That's what I thought too, but it feels counterintuitive.

[nishp1]

Thanks for this. Love it.