ServerRouter transpiled incorrectly by Babel

[steida]

Version

4.0.0

I got this error:

ReferenceError: location is not defined
   at ServerRouter.render (/Users/este/dev/este/node_modules/react-router/ServerRouter.js:58:19)

So I checked transpiled code:

}, {
    key: 'render',
    value: function render() {
      var _props = this.props;
      var context = _props.context;

      var rest = _objectWithoutProperties(_props, ['context']);

      var redirect = function redirect(location) {
        context.setRedirect(location);
      };
      return _react2.default.createElement(_StaticRouter2.default, _extends({
        action: 'POP',
        location: location,
        onReplace: redirect,
        onPush: redirect
      }, rest));
    }
  }]);

Note location is retrieved from global state. Node.js does not have it.

This is temp fix

global.location = {};

[timdorr]

That's pretty wacky. Your fix isn't correct, as the location you need to be referencing comes from props. I believe it's the arrow function and the scoping is interacting oddly with the object destructuring. I wouldnt be surprised if renaming the local variable to loc would fix it.

[Xerios]

Same here, compiling the library directly seems to work fine.
Somehow, babel misses the location variable deconstruction.

For those who are looking for a quick dirty fix (ServerRouter.js):

    var location = _props.location; // Add this line after "var context =  _props.context;"
    var rest = _objectWithoutProperties(_props, ['context', 'location']); // Add missing 'location' to the array

[Xerios]

I've locally packed and installed it with no problems.
Seems like it's just a bad transpile job, could someone republish with proper transpilation?
Thanks.

[mjackson]

Sounds like a Babel bug?

[apapirovski]

@mjackson It's not. Just no new 4.0.0 build on npm since this was committed 9eae410

[omaksi]

So any guess on when can we expect the next v4 npm build? :)

[iammerrick]

Running into this issue too:

[iammerrick]

v4.0.3 please! :-D

[timdorr]

@iammerrick We haven't released 4.0.0 yet, so why would we do 4.0.3? 😉

4.0.0-alpha.3 is out: https://github.com/ReactTraining/react-router/releases/tag/v4.0.0-alpha.3