Skip to content

Fix middle click on Links #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix middle click on Links #120

wants to merge 1 commit into from

Conversation

esamattis
Copy link
Contributor

Restore the de facto browser behavior for middle click on links: Open to
background tab.

@esamattis
Fix middle click on Links
0b0633b 
Restore the de facto browser behavior for middle click on links: Open to
background tab.
@sophiebits
Copy link
Contributor

Maybe check instead that event.button is 0? Presumably we don't want to navigate away on right clicks either (though maybe those never send click events? not sure). Also we should probably have an altKey check in there too.

@esamattis
Copy link
Contributor Author

Presumably we don't want to navigate away on right clicks either (though maybe those never send click events? not sure)

No we don't and yes they don't send the events at least Chrome and Firefox. Nevertheless I think it would be a good idea to check for zero.

@ryanflorence
Copy link
Member

thanks @epeli :)

Can you amend your commit to check the button is(n't) 0?

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esamattis @sophiebits @ryanflorence